Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support textfield and choice widgets for printing #12175

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Support textfield and choice widgets for printing #12175

merged 1 commit into from
Aug 6, 2020

Conversation

calixteman
Copy link
Contributor

There will have an other patch to handle multiline textfields and comb textfields.

@calixteman calixteman mentioned this pull request Aug 5, 2020
Closed
@timvandermeij timvandermeij added annotations form-acroform printing Gecko 81 Tracking work planned for Form Fill in Shirley 81 release labels Aug 5, 2020
timvandermeij
timvandermeij reviewed Aug 5, 2020
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Should be fine after these comments.

src/core/annotation.js Outdated Show resolved Hide resolved
src/core/annotation.js Outdated Show resolved Hide resolved
src/core/annotation.js Outdated Show resolved Hide resolved
src/core/annotation.js Outdated Show resolved Hide resolved
src/core/annotation.js Outdated Show resolved Hide resolved
src/display/annotation_layer.js Show resolved Hide resolved
src/shared/util.js Outdated Show resolved Hide resolved
test/unit/annotation_spec.js Outdated Show resolved Hide resolved
test/unit/annotation_spec.js Show resolved Hide resolved
test/unit/annotation_spec.js Outdated Show resolved Hide resolved
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Aug 6, 2020

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/39cd87bdef1f81f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 6, 2020

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/39cd87bdef1f81f/output.txt

Total script time: 3.37 mins

Published

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Aug 6, 2020

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/4ac0321797374cf/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 6, 2020

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/e22f458b355a2ea/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Aug 6, 2020

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/4ac0321797374cf/output.txt

Total script time: 27.12 mins

  • Font tests: Passed
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/4ac0321797374cf/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Aug 6, 2020

From: Bot.io (Windows)

Failed

Full output at http://54.215.176.217:8877/e22f458b355a2ea/output.txt

Total script time: 31.44 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/e22f458b355a2ea/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit 8c162f5 into mozilla:master Aug 6, 2020
@timvandermeij
Copy link
Contributor

Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandahl brendandahl brendandahl left review comments

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
annotations form-acroform Gecko 81 Tracking work planned for Form Fill in Shirley 81 release printing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @timvandermeij @pdfjsbot @brendandahl